smiklosovic commented on code in PR #330: URL: https://github.com/apache/cassandra-sidecar/pull/330#discussion_r3052807770
########## docker/cdc-demo/Dockerfile.sidecar: ########## @@ -0,0 +1,59 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +# Two-stage build: Stage 1 compiles via Gradle installDist; Stage 2 copies +# the assembled distribution into a lean JRE image. +# Usage: docker build -f docker/cdc-demo/Dockerfile.sidecar -t cassandra-sidecar:dev . + +# ── Stage 1: build ─────────────────────────────────────────────────────────── +FROM eclipse-temurin:11-jdk-jammy AS builder + +WORKDIR /build + +# Build descriptors first — keeps the dependency-download layer cached separately. Review Comment: this is confusing a bit as the user has to do "gradle jar" at least least before this is executed. Without doing "jar", what you copy will not contain "sidecar.version" and then it all passes but it fails to start like this ```` sidecar-1 | INFO [main] 2026-04-08 16:14:45,333 SidecarSchemaModule.java:59 - Registering table schema: sidecar_internal.restore_range_v1 sidecar-1 | INFO [main] 2026-04-08 16:14:45,333 SidecarSchemaModule.java:59 - Registering table schema: sidecar_internal.restore_slice_v3 sidecar-1 | Exception in thread "main" com.google.inject.ProvisionException: Unable to provision, see the following errors: sidecar-1 | sidecar-1 | 1) [Guice/ErrorInCustomProvider]: IllegalStateException: Failed to retrieve Sidecar version from resource /sidecar.version sidecar-1 | at UtilitiesModule.sidecarVersionProvider(UtilitiesModule.java:88) sidecar-1 | at ConfigurationModule.instancesMetadata(ConfigurationModule.java:175) sidecar-1 | \_ for 4th parameter sidecar-1 | at ConfigurationModule.instancesMetadata(ConfigurationModule.java:175) sidecar-1 | at InstanceMetadataFetcher.<init>(InstanceMetadataFetcher.java:51) ```` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
