andresbeckruiz commented on PR #4746: URL: https://github.com/apache/cassandra/pull/4746#issuecomment-4409338755
> do you mind checking if `LongBtreeTest#testFastBuilder` passed locally? seems to be a regression in the refactoring Just checked, that test was failing [here](https://github.com/apache/cassandra/blob/cassandra-4.1/test/burn/org/apache/cassandra/utils/LongBTreeTest.java#L734) when asserting that the `FastBuilder` buffers are empty. Seems like the `clearLeafBuffer` and `clearBranchBuffer` optimizations assume buffer invariants (eg: first null entry indicates empty buffer) that don't hold for the `FastBuilder`. In order to keep a consolidated reset method that works for both objects, I replaced these helper methods with `Arrays.fill(buffer, null)`, matching the original `FastBuilder` reset behavior. This update ensures that `LongBtreeTest#testFastBuilder` passes, along with the other BTree unit tests. I can also revert the refactor if that is preferred so that the `AbstractUpdater` can keep the optimization in its separate reset method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
