frankgh commented on code in PR #327:
URL: https://github.com/apache/cassandra-sidecar/pull/327#discussion_r3228516916
##########
client-common/src/main/java/org/apache/cassandra/sidecar/common/response/OperationalJobResponse.java:
##########
@@ -37,17 +38,35 @@ public class OperationalJobResponse
private final OperationalJobStatus status;
private final String operation;
private final String reason;
+ private final String startTime;
Review Comment:
So I've been thinking about this more. This should not be a string, we
should either have a native type (i.e. long) that represents the epoch in
milliseconds. We can still have the String version of the start time in the
OperationalJobResponse object, but it should be generated each time, and it
should not be serialized in the JSON payload. Consumers should be able to
decide how to consume the value and display it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
