skoppu22 commented on code in PR #333:
URL: https://github.com/apache/cassandra-sidecar/pull/333#discussion_r3234452588
##########
server/src/main/java/org/apache/cassandra/sidecar/utils/SSTableImporter.java:
##########
@@ -248,8 +253,7 @@ private void drainImportQueue(ImportQueue queue)
successCount++;
LOGGER.info("Successfully imported SSTables with
options={}, serviceTimeMillis={}",
options,
TimeUnit.NANOSECONDS.toMillis(serviceTimeNanos));
- promise.complete();
- cleanup(options);
+ cleanup(options).onComplete(ar -> promise.complete());
Review Comment:
I was worried this will leave files behind, accumulate and occupy storage
over the time. Reverted the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
