Copilot commented on code in PR #4819:
URL: https://github.com/apache/cassandra/pull/4819#discussion_r3263396221
##########
pylib/cqlshlib/copyutil.py:
##########
@@ -1753,7 +1753,8 @@ def format_value(self, val, cqltype):
encoding=self.encoding, colormap=NO_COLOR_MAP,
date_time_format=self.date_time_format,
float_precision=cqltype.precision,
nullval=self.nullval, quote=False,
decimal_sep=self.decimal_sep,
thousands_sep=self.thousands_sep,
- boolean_styles=self.boolean_styles)
+ boolean_styles=self.boolean_styles,
+ escape_control_chars=False)
Review Comment:
`COPY TO` now relies on `escape_control_chars=False` to preserve control
characters in CSV output. There doesn’t appear to be unit/integration coverage
exercising this path (e.g., newline/null byte preservation for text and nested
collections). Adding a test (likely under `pylib/cqlshlib/test/`) that asserts
exported values contain the actual control characters rather than their
`repr()` sequences would help prevent regressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
