andresbeckruiz commented on code in PR #349:
URL: https://github.com/apache/cassandra-sidecar/pull/349#discussion_r3269506021
##########
server/src/main/java/org/apache/cassandra/sidecar/job/OperationalJobManager.java:
##########
@@ -100,11 +100,12 @@ public void trySubmitJob(OperationalJob job,
{
checkConflict(job);
- // New job is submitted for all cases when we do not have a
corresponding downstream job
- jobTracker.computeIfAbsent(job.jobId(), jobId -> {
+ OperationalJob tracked = jobTracker.computeIfAbsent(job.jobId(),
id -> job);
Review Comment:
The goal was to separate storage of the OperationalJob from execution, but
this can be done as part of
https://issues.apache.org/jira/browse/CASSSIDECAR-374 once the
`DurableOperationalJobTracker` is introduced. Reverted this change in
[8188cfe](https://github.com/apache/cassandra-sidecar/pull/349/commits/8188cfe03829e996a8d11006caed180a4039c489)
##########
server/src/main/java/org/apache/cassandra/sidecar/job/OperationalJobManager.java:
##########
@@ -100,11 +100,12 @@ public void trySubmitJob(OperationalJob job,
{
checkConflict(job);
- // New job is submitted for all cases when we do not have a
corresponding downstream job
- jobTracker.computeIfAbsent(job.jobId(), jobId -> {
+ OperationalJob tracked = jobTracker.computeIfAbsent(job.jobId(),
id -> job);
Review Comment:
The goal was to separate storage of the `OperationalJob` from execution, but
this can be done as part of
https://issues.apache.org/jira/browse/CASSSIDECAR-374 once the
`DurableOperationalJobTracker` is introduced. Reverted this change in
[8188cfe](https://github.com/apache/cassandra-sidecar/pull/349/commits/8188cfe03829e996a8d11006caed180a4039c489)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
