absurdfarce commented on code in PR #1290:
URL:
https://github.com/apache/cassandra-python-driver/pull/1290#discussion_r3244805239
##########
cassandra/cluster.py:
##########
@@ -1424,26 +1424,26 @@ def _create_thread_pool_executor(self, **kwargs):
:return: A ThreadPoolExecutor instance.
"""
tpe_class = ThreadPoolExecutor
- if sys.version_info[0] >= 3 and sys.version_info[1] >= 7:
- try:
- from cassandra.io.eventletreactor import EventletConnection
- is_eventlet = issubclass(self.connection_class,
EventletConnection)
- except:
- # Eventlet is not available or can't be detected
- return tpe_class(**kwargs)
- if is_eventlet:
- try:
- from futurist import GreenThreadPoolExecutor
- tpe_class = GreenThreadPoolExecutor
- except ImportError:
- # futurist is not available
- raise ImportError(
- ("Python 3.7+ and Eventlet cause the
`concurrent.futures.ThreadPoolExecutor` "
- "to hang indefinitely. If you want to use the
Eventlet reactor, you "
- "need to install the `futurist` package to allow the
driver to use "
- "the GreenThreadPoolExecutor. See
https://github.com/eventlet/eventlet/issues/508 "
- "for more details."))
+ try:
+ from cassandra.io.eventletreactor import EventletConnection
+ is_eventlet = issubclass(self.connection_class, EventletConnection)
+ except ImportError:
+ # Eventlet is not available or can't be detected
+ return tpe_class(**kwargs)
+
+ if is_eventlet:
+ try:
+ from futurist import GreenThreadPoolExecutor
+ tpe_class = GreenThreadPoolExecutor
+ except ImportError:
+ # futurist is not available
+ raise ImportError(
+ ("Python 3.7+ and Eventlet cause the
`concurrent.futures.ThreadPoolExecutor` "
+ "to hang indefinitely. If you want to use the Eventlet
reactor, you "
+ "need to install the `futurist` package to allow the
driver to use "
+ "the GreenThreadPoolExecutor. See
https://github.com/eventlet/eventlet/issues/508 "
+ "for more details."))
Review Comment:
So what do we want to do with this messaging @bschoening? I think this is
really the only thing holding up this PR from going in. I'm inclined to say
that since this specific issue appears to have been fixed in eventlet (see
previous comment) we can just take all of this out in it's entirety.
The other relevant point here is that 3.30.1 will be the last release that
will even have the eventlet event loop available. It's going to be removed in
3.31.0 per [CASSPYTHON-13](https://issues.apache.org/jira/browse/CASSPYTHON-13).
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
