maedhroz commented on code in PR #4836:
URL: https://github.com/apache/cassandra/pull/4836#discussion_r3313410454
##########
test/unit/org/apache/cassandra/utils/CassandraGenerators.java:
##########
@@ -1759,8 +1760,22 @@ public static void visitUDTs(TableMetadata metadata,
Consumer<UserType> fn)
subTypes.remove(next); // it includes self
if (subTypes.isEmpty() || subTypes.stream().allMatch(t ->
visited.contains(t.name)))
{
- fn.accept(next);
+ try
+ {
+ fn.accept(next);
+ }
+ catch (Throwable t)
+ {
+ StringBuilder sb = new StringBuilder();
+ sb.append("Unable to add type
").append(next.toCqlString(false, false, false));
Review Comment:
nit: In the `toString()` for `BaseState` I guess we're not strictly changing
the schema...just building a string, but for the most part an error here does
seem to mean an error on adding the type to the schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
