belliottsmith commented on PR #277: URL: https://github.com/apache/cassandra-accord/pull/277#issuecomment-4571491238
If a test is strongly desired (I don't have a strong opinion, I am only opposed to introducing such a complex coupled test for a behaviour so trivial): an alternative might be to have `markDefunct` return a boolean indicating if it has been marked defunct, and to have a trivial test to confirm that any shard scheduler returns true exactly once. Although, we don't generally introduce such trivial tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
