maedhroz commented on code in PR #4863:
URL: https://github.com/apache/cassandra/pull/4863#discussion_r3364217421
##########
src/java/org/apache/cassandra/gms/Gossiper.java:
##########
@@ -1201,13 +1202,30 @@ private void markAlive(final InetAddressAndPort addr,
final EndpointState localS
{
Message<NoPayload> echoMessage = Message.out(ECHO_REQ, noPayload);
logger.trace("Sending ECHO_REQ to {}", addr);
- RequestCallback echoHandler = msg ->
+ RequestCallback echoHandler = new RequestCallback()
{
- runInGossipStageBlocking(() -> {
- EndpointState epState = inflightEcho.remove(addr);
- if (epState != null)
- realMarkAlive(addr, epState);
- });
+ @Override
+ public void onResponse(Message msg)
+ {
+ runInGossipStageBlocking(() -> {
+ EndpointState epState = inflightEcho.remove(addr);
+ if (epState != null)
+ realMarkAlive(addr, epState);
+ });
+ }
+
+ @Override
+ public boolean invokeOnFailure()
+ {
+ return true;
+ }
+
+ @Override
+ public void onFailure(InetAddressAndPort from,
RequestFailureReason failureReason)
Review Comment:
Should this be `RequestFailure`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
