michaelsembwever commented on code in PR #4872: URL: https://github.com/apache/cassandra/pull/4872#discussion_r3373914687
########## src/java/org/apache/cassandra/tracing/Tracing.java: ########## Review Comment: so if IIUC… we can have otel and internal-tracing off, we can have just otel, or just internal-tracing, or we have have both on. and these states don't impact the other… while the CEP has stated replacing internal-tracing as a non-goal, i am interested in vague sketching of how we could eventually do that. the only functionality needed to carry forward is the `tracing on;` output in cqlsh (any notion of sampling and querying system_traces is redundant if otel is being used). then cqlsh tracing would ideally be done in-memory only (flushing system_traces is waste). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
