smiklosovic commented on code in PR #4876:
URL: https://github.com/apache/cassandra/pull/4876#discussion_r3388704099
##########
src/java/org/apache/cassandra/dht/RangeStreamer.java:
##########
@@ -772,11 +777,15 @@ public StreamResultFuture fetchAsync()
{
String[] cfNames =
StreamPlan.nonAccordTablesForKeyspace(ksm);
if (cfNames != null)
+ {
+ cfNames = Arrays.stream(cfNames).filter(table ->
tables == null || tables.contains(table)).toArray(String[]::new);
Review Comment:
what if `this.tables` will be an empty set? Then `cfNames` will be empty
array, no? Somebody might think that empty set is "all tables".
In "rebuild" you do
tables == null || tables.isEmpty() ? "(All tables)" : tables
so null and empty is indeed as "everything" which is not the case here ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
