bdeggleston commented on code in PR #4708:
URL: https://github.com/apache/cassandra/pull/4708#discussion_r3439070818


##########
src/java/org/apache/cassandra/locator/SatelliteReplicationStrategy.java:
##########
@@ -95,6 +143,17 @@ public class SatelliteReplicationStrategy extends 
AbstractReplicationStrategy
 
     private final ReplicationFactor aggregateRf;
 
+    /**
+     * Per-range failover state.
+     * Volatile for visibility across threads.
+     *
+     * NOTE: In-memory for initial implementation. Future work will pull this
+     * from TCM (Transactional Cluster Metadata) for persistence and 
coordination.
+     *
+     * Initialized to NORMAL state for all ranges.
+     */
+    private volatile SatelliteFailoverState.FailoverStateMap failoverState;
+
     private static class SatelliteInfo

Review Comment:
   SatelliteInfo is only ever used as the value of a map, not a key, or as part 
of a set. SatelliteInfo instances are also never compared anywhere



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to