worryg0d commented on PR #1961:
URL: 
https://github.com/apache/cassandra-gocql-driver/pull/1961#issuecomment-4842532365

   The implementation in this patch fixes the regression by guarding from 
synthetic CREATED events the same way as schema keyspace listeners are guarded.
   
   Also, it adds a requirement that the internal metadata cache should be 
enabled at least at the KeyspaceOnly level for Token Aware and Custom host 
policies. But this is technically a breaking change for users who already have 
custom policies and disabled metadata, so it's probably better to just log a 
warning about it.
   
   We can introduce an optional interface that would indicate if a policy 
requires a metadata cache, and if a custom policy implements the interface, 
omit the warning:
   ```
   // MetadataRequiredPolicy is an interface that can be implemented by host 
selection policies to indicate if they require the metadata cache to be enabled.
   type MetadataRequiredPolicy interface {
        RequiresMetadata() bool
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to