beobal commented on code in PR #4899:
URL: https://github.com/apache/cassandra/pull/4899#discussion_r3498974707
##########
src/java/org/apache/cassandra/tcm/CMSOperations.java:
##########
@@ -80,6 +83,65 @@ private CMSOperations(ClusterMetadataService cms)
this.cms = cms;
}
+ // TCM CMS await timeout
+ public long getCmsAwaitTimeoutMillis()
+ {
+ return DatabaseDescriptor.getCmsAwaitTimeout().to(MILLISECONDS);
+ }
+
+ public void setCmsAwaitTimeoutMillis(long timeoutInMillis)
+ {
+ Preconditions.checkState(timeoutInMillis > 0);
+ DatabaseDescriptor.setCmsAwaitTimeout(timeoutInMillis);
+ }
+
+ // CMS commit timeout with exponential backoff
+ public long getCmsCommitTimeoutMillis()
+ {
+ return DatabaseDescriptor.getCmsCommitTimeout().to(MILLISECONDS);
+ }
+
+ public void setCmsCommitTimeoutMillis(long timeoutInMillis)
+ {
+ Preconditions.checkState(timeoutInMillis > 0);
+ DatabaseDescriptor.setCmsCommitTimeout(timeoutInMillis);
+ }
+
+ public long getCmsCommitRetryInitialDelayMillis()
+ {
+ return
DatabaseDescriptor.getCmsCommitRetryInitialDelay().to(MILLISECONDS);
+ }
+
+ public void setCmsCommitRetryInitialDelayMillis(long delayInMillis)
+ {
+ Preconditions.checkState(delayInMillis > 0);
+ DatabaseDescriptor.setCmsCommitRetryInitialDelay(delayInMillis);
+ }
+
+ public long getCmsCommitRetryMaxDelayMillis()
+ {
+ return DatabaseDescriptor.getCmsCommitRetryMaxDelay().to(MILLISECONDS);
+ }
+
+ public void setCmsCommitRetryMaxDelayMillis(long delayInMillis)
+ {
+ Preconditions.checkState(delayInMillis > 0);
+ DatabaseDescriptor.setCmsCommitRetryMaxDelay(delayInMillis);
+ }
+
+ @Override
+ public String getCmsCommitMemberPreferencePolicy()
+ {
+ return DatabaseDescriptor.getCmsCommitMemberPreferencePolicy().name();
+ }
+
+ @Override
+ public void setCmsCommitMemberPreferencePolicy(String policy)
+ {
+ DatabaseDescriptor.setCmsCommitMemberPreferencePolicy(policy);
+ logger.info("Set cms_commit_member_preference_policy to {}", policy);
+ }
+
Review Comment:
Actually, I had missed removing them from `StorageService`. I've properly
relocated them now, rebased on latest 6.0 and re-submitted CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
