andresbeckruiz commented on code in PR #359:
URL: https://github.com/apache/cassandra-sidecar/pull/359#discussion_r3507355914


##########
server/src/main/java/org/apache/cassandra/sidecar/job/storage/OperationalJobRecord.java:
##########
@@ -173,6 +179,70 @@ public Map<String, String> operationMetadata()
         return operationMetadata;
     }
 
+    @Override
+    @Nullable
+    public UUID nodeId()
+    {
+        return null;

Review Comment:
   `nodeId` was not added to the cluster ops schema because for cluster-wide 
records, there's no single associated node. Per-node state is tracked 
separately in the `cluster_ops_node_state` table, and the nodes included in a 
job are recorded in the `node_execution_order` column. 
   
   `nodeId` is part of the `OperationalJobInfo` interface, which was designed 
to capture the common read-only fields from `OperationalJob`. `nodeId` already 
existed for single-node jobs (drain, decommission, move). Since 
`OperationalJobRecord` now implements this interface, it returns null since 
cluster-wide records aren't associated with a single node. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to