krummas commented on code in PR #4915:
URL: https://github.com/apache/cassandra/pull/4915#discussion_r3519633155
##########
src/java/org/apache/cassandra/service/Rebuild.java:
##########
@@ -232,7 +232,7 @@ private static RangesAtEndpoint
rangesForRebuildWithTokens(String tokens, String
private static MovementMap movementMap(ClusterMetadata metadata, String
keyspace, String tokens)
{
MovementMap.Builder movementMapBuilder = MovementMap.builder();
- DataPlacements placements = metadata.placements;
+ DataPlacements placements = metadata.placements();
Review Comment:
I think this changes behaviour now when meta placements are not here? I
guess it makes sense to be able to rebuild meta ks?
##########
src/java/org/apache/cassandra/tcm/transformations/cms/AdvanceCMSReconfiguration.java:
##########
@@ -238,29 +222,25 @@ private Transformation.Result
executeRemove(ClusterMetadata prev, ReconfigureCMS
List<NodeId> newRemovals = new ArrayList<>(diff.removals.subList(1,
diff.removals.size()));
// Check that the candidate is actually a CMS member
- ClusterMetadata.Transformer transformer = prev.transformer();
+ Set<NodeId> cms = prev.fullCMSMemberIds();
InetAddressAndPort endpoint = prev.directory.endpoint(removal);
- Replica replica = new Replica(endpoint, entireRange, true);
- ReplicationParams metaParams = ReplicationParams.meta(prev);
- if (!prev.fullCMSMembers().contains(endpoint))
+ if (!prev.fullCMSMemberIds().contains(removal))
Review Comment:
nit, `cms.contains(...)`
##########
src/java/org/apache/cassandra/tcm/ownership/DataPlacements.java:
##########
Review Comment:
unused
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
