yifan-c commented on code in PR #4913:
URL: https://github.com/apache/cassandra/pull/4913#discussion_r3522846506
##########
.build/parent-maven-pom.xml:
##########
@@ -304,6 +304,25 @@
<groupId>com.github.luben</groupId>
<artifactId>zstd-jni</artifactId>
<version>1.5.7-2</version>
+ <classifier>linux_aarch64</classifier>
+ </dependency>
+ <dependency>
+ <groupId>com.github.luben</groupId>
+ <artifactId>zstd-jni</artifactId>
+ <version>1.5.7-2</version>
+ <classifier>linux_amd64</classifier>
+ </dependency>
+ <dependency>
+ <groupId>com.github.luben</groupId>
+ <artifactId>zstd-jni</artifactId>
+ <version>1.5.7-2</version>
+ <classifier>darwin_aarch64</classifier>
+ </dependency>
+ <dependency>
+ <groupId>com.github.luben</groupId>
+ <artifactId>zstd-jni</artifactId>
+ <version>1.5.7-2</version>
+ <classifier>darwin_x86_64</classifier>
Review Comment:
I think we are missing the `activation` label in order to build
conditionally based on the platform.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
