absurdfarce commented on code in PR #2093:
URL:
https://github.com/apache/cassandra-java-driver/pull/2093#discussion_r3546938510
##########
core/src/main/java/com/datastax/dse/driver/internal/core/data/geometry/DefaultGeometry.java:
##########
@@ -176,7 +176,7 @@ public boolean equals(Object o) {
return false;
}
DefaultGeometry that = (DefaultGeometry) o;
- return this.getOgcGeometry().equals((Object) that.getOgcGeometry());
+ return this.getOgcGeometry().Equals(that.getOgcGeometry());
Review Comment:
I'm becoming increasingly convinced that the [earlier
change](https://github.com/apache/cassandra-java-driver/pull/2077) was indeed
incorrect. Prior to that update we were doing the following for
DefaultGeometry.equals():
`return this.getOgcGeometry().equals(that.getOgcGeometry());`
That leverages the
[equals(OGCGeometry)](https://github.com/Esri/geometry-api-java/blob/v1.2.1/src/main/java/com/esri/core/geometry/ogc/OGCGeometry.java#L213-L222)
method in ESRI 1.2.1. ESRI 2.2.4 introduced an
[equals(Object)](https://github.com/Esri/geometry-api-java/blob/v2.2.4/src/main/java/com/esri/core/geometry/ogc/OGCGeometry.java#L809-L841)
impl in the PR referenced elsewhere but the meaning is different from the old
equals() impl. The old implementation has been moved to
[Equals(OGCGeometry)](https://github.com/Esri/geometry-api-java/blob/v2.2.4/src/main/java/com/esri/core/geometry/ogc/OGCGeometry.java#L250-L269)
in 2.2.4... that's what we should have moved to originally (and what this PR
does move us to).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
