andresbeckruiz commented on code in PR #360:
URL: https://github.com/apache/cassandra-sidecar/pull/360#discussion_r3553152485
##########
server/src/main/java/org/apache/cassandra/sidecar/job/OperationalJobManager.java:
##########
@@ -41,18 +43,33 @@ public class OperationalJobManager
{
protected final Logger logger = LoggerFactory.getLogger(this.getClass());
private final OperationalJobTracker jobTracker;
-
+ @Nullable
+ private final OperationalJobCoordinator coordinator;
Review Comment:
Good idea. Replaced the `@Nullable OperationalJobCoordinator` with a
`DisabledOperationalJobCoordinator` in
[509b15b](https://github.com/apache/cassandra-sidecar/pull/360/commits/509b15b3d41bcc40c4ef46cd9c53439edc3654bd)
To clarify, backwards compatibility for existing uncoordinated jobs (eg:
decommission) is already handled by `requiresCoordination() == false`, so they
short circuit before touching the coordinator. Therefore, the
`DisabledOperationalJobCoordinator` only matters for a job requiring
coordination submitted to an instance without coordination support.
Also updated this patch to bind the `OperationalJobCoordinator` to the
`DisabledOperationalJobCoordinator`. Configuration to enable this class (as
well as durable tracking) will be added in CASSSIDECAR-378.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
