arvindKandpal-ksolves commented on code in PR #4922:
URL: https://github.com/apache/cassandra/pull/4922#discussion_r3557347192
##########
src/java/org/apache/cassandra/tools/nodetool/Compact.java:
##########
@@ -118,4 +128,149 @@ else if (partitionKeyProvided)
}
}
}
+
Review Comment:
I see a backward compatibility edge case here. If a user has a keyspace
actually named keyspace or range, running the legacy command like nodetool
compact keyspace mytable will trigger the new subcommand instead of treating it
as the keyspace name. The same issue would happen if a file is named sstables.
Any suggestions on what's the standard way in the codebase to handle this
kind of picocli name collision? Should I add some custom check before picocli
parses the arguments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
