absurdfarce commented on code in PR #1293: URL: https://github.com/apache/cassandra-python-driver/pull/1293#discussion_r3549504645
########## tests/integration/long/test_ssl.py: ########## @@ -22,8 +22,6 @@ from cassandra import ConsistencyLevel Review Comment: Note to self: the changes here will stomp on the [PR](https://github.com/apache/cassandra-python-driver/pull/1232) to get test_ssl.py working again. That's not a problem; we need both of these changes for 4.x so it has to happen one way or another. Just making the note here so I don't forget it. ########## test-requirements.txt: ########## @@ -4,9 +4,7 @@ pytest ccm>=3.1.5 pytz pure-sasl -twisted[tls] -gevent -eventlet cython>=3.0 packaging asynctest +cryptography>=42.0 Review Comment: We used to get cryptography in our venv as a transitive dependency of Twisted. Now that that has been removed (correctly) we need to explicitly add cryptography here to make the column encryption tests happy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
