bianca-stanciu29 commented on code in PR #365:
URL: https://github.com/apache/cassandra-sidecar/pull/365#discussion_r3571091050
##########
CHANGES.txt:
##########
@@ -8,6 +8,7 @@
0.4.0
-----
+ * Fix restore job failing with "Keyspace does not exist" for quoted
mixed-case keyspace names (CASSSIDECAR-475)
Review Comment:
Hey @skoppu22, @frankgh, @yifan-c just wanted to let you know I've
addressed all the feedback!
For the null check and regression concerns raised by @skoppu22 and @frankgh,
I replaced all the raw `getKeyspace` / `quoteIfNecessary` calls with a
`MetadataUtils.keyspace()` helper that does a two-step lookup: tries the raw
name first, then falls back to the quoted version. This way it handles both
regular lowercase keyspaces and mixed-case quoted ones without any regression.
For @yifan-c 's point about missing code paths, you were right,
`ValidateTableExistenceHandler` wasn't covered. Fixed that too, and updated
`RestoreJobDiscovererPhaseSignalIntTest` to use the mixed-case name exactly as
you suggested in your comment.
Everything is in commit `f7f73187`. Thanks for the thorough review, let me
know if anything else needs attention!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
