worryg0d commented on code in PR #1942:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1942#discussion_r3577311030
##########
marshal.go:
##########
@@ -2749,9 +2749,12 @@ func (udtCQLType) TypeInfoFromParams(proto int, params
[]interface{}) (TypeInfo,
return nil, fmt.Errorf("expected []UDTField for udt, got %T",
params[2])
}
return UDTTypeInfo{
- Keyspace: keyspace,
- Name: name,
- Elements: elements,
+ Keyspace: keyspace,
+ Name: name,
+ Elements: elements,
+ encodeNilMapAsNull: u.types.encodeNilMapAsNull,
+ warnOnNilMap: u.types.warnOnNilMap,
+ logger: u.types.logger,
}, nil
Review Comment:
The issue is that it might panic if `WithNullableUDTs` is not called due to
a nil logger, but it is in our control, so it's probably not a big thing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
