netudima commented on code in PR #4939:
URL: https://github.com/apache/cassandra/pull/4939#discussion_r3590265765


##########
.build/run-ci:
##########
@@ -275,6 +276,19 @@ def install_jenkins(kubeconfig: Optional[str], 
kubecontext: Optional[str], kube_
         sys.exit(1)
 
 
+def wait_for_jenkins_http(ip: str, timeout: int = 300):
+    host, port = (ip.rsplit(":", 1)[0], int(ip.rsplit(":", 1)[1])) if ":" in 
ip else (ip, 80)
+    spin_while(f"Waiting for Jenkins HTTP at {host}:{port}… ", lambda: 
_tcp_connect_ok(host, port))

Review Comment:
   nit: it looks like we do not use a timeout, so technically it can be an 
infinite loop



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to