kinow commented on a change in pull request #1153:
URL: https://github.com/apache/jena/pull/1153#discussion_r777265148
##########
File path: jena-fuseki2/jena-fuseki-ui/src/styles/index.scss
##########
@@ -15,7 +15,7 @@
* limitations under the License.
*/
-@import 'node_modules/bootstrap/scss/bootstrap';
+@import
'node_modules/bootstrap-vue/node_modules/bootstrap/scss/bootstrap.scss';
Review comment:
Commit message has a link to the README of Bootstrap Vue, where they
changed the recommended way to import it (I got a warning using the old way)
##########
File path: jena-fuseki2/jena-fuseki-ui/src/views/dataset/Query.vue
##########
@@ -212,8 +212,8 @@ export default {
this.onYasqeOptionsChange()
this.syncYasqePrefixes()
this.loading = false
- })
- }, 300)
+ }, 300)
+ })
Review comment:
:lady_beetle: it worked because JS accepts the extra parameter in the
wrong function, and then appears to just use `0` (like a `this.wait()` in Java
I think).
##########
File path: jena-fuseki2/jena-fuseki-ui/.eslintrc.js
##########
@@ -30,7 +30,8 @@ module.exports = {
rules: {
'no-console': process.env.NODE_ENV === 'production' ? 'warn' : 'off',
'no-debugger': process.env.NODE_ENV === 'production' ? 'warn' : 'off',
- 'vue/custom-event-name-casing': 'off'
+ 'vue/custom-event-name-casing': 'off',
+ 'vue/multi-word-component-names': 'off'
Review comment:
When we update the linter, and the Vue plug-ins for the eslinter, it's
normal to see new rules that were incorporated by the plug-in, but that are
just really annoying for us :-) in cases like this I simply disable it, unless
it's a rule that appears to be useful.
##########
File path: jena-fuseki2/jena-fuseki-ui/package.json
##########
@@ -13,38 +13,38 @@
"test:unit": "vue-cli-service test:unit"
},
"dependencies": {
- "@fortawesome/fontawesome-svg-core": "^1.2.35",
- "@fortawesome/free-solid-svg-icons": "^5.15.3",
- "@fortawesome/vue-fontawesome": "^2.0.2",
- "@triply/yasqe": "^4.2.7",
- "@triply/yasr": "^4.2.8",
- "axios": "^0.21.1",
- "bootstrap": "^4.6.0",
+ "@fortawesome/fontawesome-svg-core": "^1.2.36",
+ "@fortawesome/free-solid-svg-icons": "^5.15.4",
+ "@fortawesome/vue-fontawesome": "^2.0.6",
+ "@triply/yasqe": "^4.2.20",
+ "@triply/yasr": "^4.2.20",
+ "axios": "^0.24.0",
+ "bootstrap": "^5.1.3",
Review comment:
Sorry, when I finished the PR they were finishing the version 5. I
upgraded Skosmos from 3 to 5, but forgot to upgrade the Fuseki PR. Will try to
review what changed, and what needs to be fixed (luckily we don't use Bootstrap
per se, but Bootstrap Vue, which abstracts the Bootstrap syntax for us)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
