kinow commented on a change in pull request #1159:
URL: https://github.com/apache/jena/pull/1159#discussion_r780812990
##########
File path:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/server/DataAccessPointRegistry.java
##########
@@ -58,11 +61,29 @@ private void register(String name, DataAccessPoint
accessPt) {
}
}
- /** @deprecated Use {@link #register(DataAccessPoint)} */
+ /**
+ * Collection of the {@link DataAccessPoint DataAccessPoints}. This is a
new list
+ * generated from the registry contents and not still connected to the
registry.
+ * Registry changes will not interfere with iteration over the list.
+ * {@link DataAccessPoint DataAccessPoints} can not be registered twice
under
+ * differerent names (the same dataset can be via different
Review comment:
Missing closing `)`?
##########
File path:
jena-db/jena-tdb2/src/test/java/org/apache/jena/tdb2/graph/TestPrefixMappingTDB2.java
##########
@@ -29,7 +29,7 @@
import org.junit.Before;
import org.junit.BeforeClass;
-public class TestPrefixMappingTDB extends AbstractTestPrefixMappingView
+public class TestPrefixMappingTDB2 extends AbstractTestPrefixMappingView
Review comment:
:+1: Good for logging/quickly finding classes in the IDE, without having
to look at the package name, great improvement!
##########
File path:
jena-arq/src/main/java/org/apache/jena/sparql/core/DatasetGraphBase.java
##########
@@ -84,6 +84,7 @@ public Graph getUnionGraph() {
@Override
public abstract void removeGraph(Node graphName) ;
+ @Deprecated
Review comment:
Do we need to suggest an alternative in a javadoc deprecated? Or is it
unlikely or not supposed to be used by other devs?
##########
File path: jena-arq/src/main/java/org/apache/jena/sparql/core/DatasetGraph.java
##########
@@ -69,10 +69,13 @@
*/
public boolean containsGraph(Node graphNode) ;
- /** Set the default graph. Set the active graph if it was null.
- * This replaces the contents default graph, not merge data into it.
- * Do not assume that the same object is returned by {@link
#getDefaultGraph}
+ /**
+ * Set the default graph.
+ * This replaces the contents default graph, not merge data into it.
Review comment:
does not merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
