afs commented on PR #1343: URL: https://github.com/apache/jena/pull/1343#issuecomment-1140449274
> Just a minor remark: E_IRI should have a public getBase() method yes, and more! The second commit add a 2-argument form `IRI(baseExpr, rel)`. For update, I think that this general form might be useful for translating data. Experimental. That'll need accessors to the state of E_IRI that "ExprFunction1" does not expose for printing (to SSE and to SPARQL) - WIP. Whether it is better to be an "ExprFunction2" or "ExprFunctionN" isn't clear. `IRI` is still primarily a one-argument function. because it retains how it was setup (implicit base or explicit base), it isn't a true "ExprFunction2" either. (And some of this code structure is really old!) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
