afs commented on code in PR #1330:
URL: https://github.com/apache/jena/pull/1330#discussion_r894791871
##########
jena-geosparql/pom.xml:
##########
@@ -67,6 +67,11 @@
<artifactId>jts-core</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.locationtech.jts.io</groupId>
+ <artifactId>jts-io-common</artifactId>
Review Comment:
There are licensing considerations for this artifact.
It is available under EDL 1.0 (Eclipse Distribution License) which is
acceptable - it requires an acknowledgement in any binaries Apache Jena ships
(jena-geosparql, jena-fuseki-geosparql).
That should already be covered by jts-core
There do not seem to be any recursive dependencies.
##########
jena-geosparql/src/test/java/org/apache/jena/geosparql/geof/nontopological/filter_functions/AsGeoJSONFFTest.java:
##########
@@ -0,0 +1,61 @@
+package org.apache.jena.geosparql.geof.nontopological.filter_functions;
+
+import org.apache.jena.geosparql.implementation.datatype.GMLDatatype;
+import org.apache.jena.geosparql.implementation.datatype.GeoJSONDatatype;
+import org.apache.jena.sparql.expr.NodeValue;
+import org.junit.*;
+import org.locationtech.jts.geom.GeometryFactory;
+import org.locationtech.jts.geom.LineString;
+import org.locationtech.jts.io.ParseException;
+import org.locationtech.jts.io.geojson.GeoJsonReader;
+
+import static org.junit.Assert.assertTrue;
+
+public class AsGeoJSONFFTest {
+ private static final double TOLERANCE = 0.0001;
+
+ public AsGeoJSONFFTest() {
+ }
+
+ @BeforeClass
Review Comment:
These don't need to be heer if they are empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
