ericprud commented on code in PR #1637:
URL: https://github.com/apache/jena/pull/1637#discussion_r1032627348
##########
jena-shex/src/test/java/org/apache/jena/shex/runner/ShexT.java:
##########
@@ -74,4 +81,12 @@ public class ShexT {
public final static Property sx_json =
ResourceFactory.createProperty(NS_SX + "json");
public final static Property sx_ttl =
ResourceFactory.createProperty(NS_SX + "ttl");
+
+ /** <p>The test statusThe expected output of semantic actions</p> */
Review Comment:
Typo faithfully copied from
`jena-core/src/main/java/org/apache/jena/vocabulary/TestManifest.java:42`
fixed.
##########
jena-shex/src/test/java/org/apache/jena/shex/runner/ShexTests.java:
##########
@@ -329,10 +325,41 @@ private static boolean
runTestExclusionsInclusions(ManifestEntry entry) {
//System.err.println("Skipping: "+fragment);
return false;
}
+
+ List<Resource> traits = extractTraits(entry);
+ if (traits != null) {
+ List<Resource> excludedBecause = traits.stream().filter(excl
-> excludeTraits.contains(excl)).collect(Collectors.toList());
Review Comment:
I compose the `excludedBecause` because (because because) I used it to see
why tests were excluded. It could be nice to have a command-line arg to log it
but at least this way you can println it to chase down mysteries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
