kinow commented on code in PR #1734:
URL: https://github.com/apache/jena/pull/1734#discussion_r1090068972
##########
jena-fuseki2/jena-fuseki-ui/package.json:
##########
@@ -7,15 +7,15 @@
"license": "Apache-2.0",
"scripts": {
"dev": "vite",
- "serve": "vite preview --port 8080",
+ "serve": "vite preview",
"build": "vite build",
"test:unit": "vitest run --environment jsdom",
- "test:e2e": "bash -c 'concurrently --names \"SERVER,TESTS\"
--prefix-colors \"yellow,blue\" --success \"first\" --kill-others \"yarn run
serve:offline\" \"cross-env CYPRESS_COVERAGE=false cypress run ${0}\"'",
+ "test:e2e": "concurrently --names 'SERVER,CLIENT,TESTS' --prefix-colors
'yellow,blue,green' --success 'first' --kill-others 'yarn run serve:fuseki'
'yarn wait-on http://localhost:${FUSEKI_PORT}/ping && yarn run dev' 'yarn
wait-on http-get://localhost:${PORT}/index.html && cypress run ${0}'",
"lint": "eslint --ext .js,.vue --ignore-path .gitignore --fix src",
- "coverage:unit": "vitest run --environment jsdom --coverage",
- "coverage:e2e": "bash -c 'concurrently --names \"SERVER,TESTS\"
--prefix-colors \"yellow,blue\" --success \"first\" --kill-others \"yarn run
serve:offline\" \"cross-env CYPRESS_COVERAGE=true cypress run ${0}\"'",
+ "coverage:unit": "yarn run test:unit -- --coverage",
+ "coverage:e2e": "cross-env-shell CYPRESS_COVERAGE=true yarn run test:e2e",
"serve:fuseki": "nodemon src/services/mock/json-server.js",
- "serve:offline": "concurrently --names 'SERVER,CLIENT' --prefix-colors
'yellow,blue' --success \"first\" --kill-others 'yarn run serve:fuseki' 'yarn
run dev'"
+ "serve:offline": "cross-env FUSEKI_PORT=\"${FUSEKI_PORT:=3030}\"
PORT=\"${PORT:=8080}\" concurrently --names 'SERVER,CLIENT' --prefix-colors
'yellow,blue' --success 'first' --kill-others 'yarn run serve:fuseki' 'yarn
wait-on http://localhost:${FUSEKI_PORT}/ping && yarn run dev'"
Review Comment:
Also, it uses `wait-on` anyway (didn't know before, learned reading their
docs just now). So no much difference to adding `wait-on` with `concurrently`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
