afs commented on code in PR #1774: URL: https://github.com/apache/jena/pull/1774#discussion_r1122827682
########## jena-core/src/main/java/org/apache/jena/rdfxml/xmlinput0/ARP0.java: ########## @@ -0,0 +1,235 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +/* This file includes contributions by: + * (c) Copyright 2003, Plugged In Software + * See end of file for BSD-style license. + */ + +package org.apache.jena.rdfxml.xmlinput0; +import java.io.IOException; +import java.io.InputStream; +import java.io.Reader; + +import org.apache.jena.rdfxml.xmlinput0.impl.RDFXMLParser; +import org.xml.sax.ErrorHandler; +import org.xml.sax.InputSource; +import org.xml.sax.Locator; +import org.xml.sax.SAXException; + + +/** Another RDF Parser. + * To load an RDF file: + * <ol> + * <li>Create an ARP.</li> + * <li>Set its handlers, by calling the {@link #getHandlers} + * method, and then.</li> + * <ul> + * <li>Setting the statement handler.</li> + * <li>Optionally setting the other handlers.</li> + * </ul> + * + * </li> + * <li>Call a load method.</li> + * </ol> + * <p> + * Xerces is used for parsing the XML. + * The SAXEvents generated by Xerces are then + * analysed as RDF by ARP. + * Errors may occur + * in either the XML or the RDF part, see + * {@link ARPHandlers#setErrorHandler} for details + * of how to distinguish between them.</p> + * <p> + * For very large files, ARP does not use any additional + * memory except when either the {@link ExtendedHandler#discardNodesWithNodeID} + * returns false or when the {@link AResource#setUserData} method has been + * used. In these cases ARP needs to remember the <code>rdf:nodeID</code> + * usage through the file life time. </p> + * <p>See <a href="/documentation/io/index.html">ARP documentation</a> for more information.</p> + * Includes contributions from Simon Raboczi and Andrew Newman + */ +public class ARP0 implements ARPConfig +{ + + final private RDFXMLParser arpf; + +/** Creates a new RDF Parser. + * Can parse one file at a time. + */ Review Comment: Yes. And weird code indentation. `xmlinput0`, the code up to 4.7.0, is minimally touched by this PR so there is a way to switch back. For the upgraded code, I've reformatted some code in areas the PR touches but not gone through the codebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
