afs commented on code in PR #1806:
URL: https://github.com/apache/jena/pull/1806#discussion_r1141786639
##########
jena-arq/src/main/java/org/apache/jena/sparql/expr/E_IRI.java:
##########
@@ -74,14 +74,15 @@ protected NodeValue evalSpecial(Binding binding,
FunctionEnv env) {
/*package*/ static NodeValue resolve(NodeValue relative, String baseIRI,
FunctionEnv env) {
if ( baseIRI == null ) {
- // Legacy
if ( env.getContext() != null ) {
Query query =
(Query)env.getContext().get(ARQConstants.sysCurrentQuery);
if ( query != null )
baseIRI = query.getBaseURI();
+ // If still null, NodeFunctions.iri will use the system base.
+// if ( baseIRI == null )
+// baseIRI = IRIs.getBaseStr();
Review Comment:
It's not necessary, it does document an assumption about the behaviour of
NodeFunctions.iri.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
