afs commented on code in PR #2097:
URL: https://github.com/apache/jena/pull/2097#discussion_r1397120028
##########
jena-core/src/main/java/org/apache/jena/shared/impl/PrefixMappingImpl.java:
##########
@@ -49,8 +50,8 @@ public PrefixMappingImpl()
{
// ConcurrentHashMaps protects against breaking each datastructure
// but does not protect against inconsistency.
- prefixToURI = new ConcurrentHashMap<>();
- URItoPrefix = new ConcurrentHashMap<>();
+ prefixToURI = new ConcurrentSkipListMap<>();
+ URItoPrefix = new ConcurrentSkipListMap<>();
}
Review Comment:
The order of entries in a PrefixMapping is not guaranteed. This part of the
contract of for `PrefixMapping`.
There are other implementations of `PrefixMapping`.
Where is this a problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
