wang3820 commented on PR #2096: URL: https://github.com/apache/jena/pull/2096#issuecomment-1816947521
> Can you describe why this test is flaky, or show an environment where it fails? > > The test case you mention is already designed to be resistant to variable ordering of the returned injections so not sure what this is gaining us here **Nondex** was used to check and locate the flakiness in the test. The test can be reproduced using the following command: ```shell mvn install -pl jena-arq -am -DskipTests mvn -pl jena-arq test -Dtest=org.apache.jena.query.TestParameterizedSparqlString#test_param_string_injection_10 mvn -pl jena-arq edu.illinois:nondex-maven-plugin:2.1.7-SNAPSHOT:nondex -Dtest=org.apache.jena.query.TestParameterizedSparqlString#test_param_string_injection_10 ``` How nondex works is that it shuffles collection objects that does not guarantee order, like `HashMap`, while running the test and see it fails because of some assumptions were made based on the order is maintained. From my understanding, since the variable ordering is retrieved from the `HashMap`, the returned injection order could be wrong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
