rvesse commented on code in PR #2100:
URL: https://github.com/apache/jena/pull/2100#discussion_r1404128316
##########
jena-extras/jena-querybuilder/src/main/java/org/apache/jena/arq/querybuilder/handlers/WhereHandler.java:
##########
@@ -165,22 +166,14 @@ public ElementGroup getClause() {
* @param t The trip to test.
*/
private static void testTriple(TriplePath t) {
+ Predicate<Node> checkPredicate = n -> n.isURI() || n.isVariable()
||n.equals(Node.ANY);
+
+ Predicate<Node> checkSubject = n -> checkPredicate.test(n) ||
n.isBlank() || n.isNodeTriple();
+
Review Comment:
Nitpick, these predicate definitions could probably be `private static
final` fields
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
