kinow commented on code in PR #2134:
URL: https://github.com/apache/jena/pull/2134#discussion_r1436625836
##########
jena-base/src/main/java/org/apache/jena/atlas/lib/Lib.java:
##########
@@ -112,25 +113,42 @@ static public UnsupportedOperationException
unsupportedMethod(Object object, Str
/** Do two lists have the same elements without considering the order of
the lists nor duplicates? */
public static <T> boolean equalsListAsSet(List<T> list1, List<T> list2) {
if ( list1 == null && list2 == null )
- return true ;
- if ( list1 == null ) return false ;
- if ( list2 == null ) return false ;
- return list1.containsAll(list2) && list2.containsAll(list1) ;
+ return true;
+ if ( list1 == null ) return false;
+ if ( list2 == null ) return false;
+ return list1.containsAll(list2) && list2.containsAll(list1);
}
/** HashCode - allow nulls */
- public static final int hashCodeObject(Object obj) { return
hashCodeObject(obj, -4) ; }
+ public static final int hashCodeObject(Object obj) { return
hashCodeObject(obj, -4); }
/** HashCode - allow nulls */
public static final int hashCodeObject(Object obj, int nullHashCode) {
if ( obj == null )
- return nullHashCode ;
- return obj.hashCode() ;
+ return nullHashCode;
+ return obj.hashCode();
+ }
+
+ public static boolean isEmpty(CharSequence cs) {
+ // Hide implementation
+ return StringUtils.isEmpty(cs);
+ }
+
+ /** Non-locale lowercase {@link Locale#ROOT} */
+ public static String lowercase(String string) {
+ // Hide implementation
+ return string.toLowerCase(Locale.ROOT);
+ }
+
+ /** Non-locale uppercase {@link Locale#ROOT} */
+ public static String uppercase(String string) {
+ // Hide implementation
+ return string.toUpperCase(Locale.ROOT);
Review Comment:
> for "system" use
:+1: then I think this is fine, marking as resolved! Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
