kinow commented on code in PR #2164:
URL: https://github.com/apache/jena/pull/2164#discussion_r1447622241
##########
jena-tdb2/src/main/java/org/apache/jena/tdb2/store/NodeIdFactory.java:
##########
@@ -102,7 +102,7 @@ private static NodeId create(int v1, long v2) {
int t = v1 >> 24;
NodeIdType type = NodeIdType.intToEnum(t);
if ( type == NodeIdType.SPECIAL )
- throw new TDBException(String.format("Attempt to create a special
from a long: 0x%016", v2));
+ throw new TDBException(String.format("Attempt to create a special
from a long: 0x%016X", v2));
Review Comment:
These two changes were the only ones I was not sure. Can't recall ever using
this syntax. The rest of the changes look good!
##########
jena-db/jena-dboe-trans-data/src/main/java/org/apache/jena/dboe/trans/data/TransBinaryDataFile.java:
##########
@@ -166,7 +166,7 @@ protected void _abort(TxnId txnId, TxnBinFile
txnResetState) {
// Internal consistency check.
// (Abort after commit would trigger the warning.)
if ( txnResetState.length != x )
- Log.warn(this, format("Mismatch: state.length = %d,
committedLength = %d", txnResetState.length != x));
+ Log.warn(this, format("Mismatch: state.length = %d,
committedLength = %d", txnResetState.length, x));
Review Comment:
Looks like a copy-pasta bug! Good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
