afs commented on code in PR #2298:
URL: https://github.com/apache/jena/pull/2298#discussion_r1507480283
##########
jena-fuseki2/jena-fuseki-main/src/main/java/org/apache/jena/fuseki/main/FusekiServer.java:
##########
@@ -1383,12 +1399,12 @@ private static void
prepareDataServices(DataAccessPointRegistry dapRegistry, Ope
}
/**
- * Given a ServletContextHandler, set the servlet attributes for
- * {@link DataAccessPointRegistry} and {@link OperationRegistry}.
+ * Given a ServletContextHandler, set the servlet attributes for
{@link DataAccessPointRegistry} and
+ * {@link OperationRegistry}.
*/
private static void applyDatabaseSetup(ServletContextHandler handler,
-
DataAccessPointRegistry dapRegistry,
- OperationRegistry
operationReg) {
+ DataAccessPointRegistry
dapRegistry,
+ OperationRegistry operationReg)
{
Review Comment:
That one specifically is a fault in the current codebase. Looks like a
method rename in initial development.
The others (and ones that seem to have disappeared from an earlier state)
are just "different format" and will lead to thrashing back and forth.
The Jena codebase has [a loose
style](https://github.com/apache/jena/blob/main/CONTRIBUTING.md#code). There is
a balance between excessive clearing up (and history disruption) and converting
some of the more unusual styles to more modern forms.
For me, the git history is what matters so cleanup as separate commits to
functional changes works when the cleanup is in the same area.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
