kinow commented on PR #1792:
URL: https://github.com/apache/jena/pull/1792#issuecomment-1987349948
Alright, I have a local version that contains the function split into two,
and I think I understood more about the goal of this issue (also spotted that I
didn't add pagination to Edit, only to Info view).
@afs there are a few things to confirm on this PR.
- So this PR disables the `COUNT(*)` queries for the graphs by default
- It eagerly loads the list of graphs once you open the Edit view (even
though we still have the button to count graphs)
- What would be the best?
- a. load all graphs by default, without the count once the page is
loaded, wait for user to click to count all graphs?
- b. load all graphs by default, without the count once the page is
loaded, do not let users click on count (go to Info view instead)
- c. load nothing by default, wait for user to click and then load
graphs without count
- Even though we are removing the `COUNT((*)`, that's still required... when
you edit the graph, the UI uses that `COUNT` to compare against
`MAX_EDITABLE_SIZE`, set in the code to `10000` (from old Fuseki UI)
- Should we let users try to save very large graphs and possibly overload
UI and/or backend? i.e. drop the limit/need for count
- Or should we load the count when the user tries to save it (or when s/he
clicks on it?
Some screenshots from the current version in this PR:
(when you open the Edit view, it queries the backend when the page is loaded)
(when you click count triples, it's the same as `main` branch)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
