afs commented on code in PR #2333:
URL: https://github.com/apache/jena/pull/2333#discussion_r1524848614
##########
jena-arq/src/test/java/org/apache/jena/system/GTest.java:
##########
@@ -34,8 +35,6 @@ public void copy() {
{
var graphImplementingCopyable = new GraphMem2Fast();
- assertTrue(graphImplementingCopyable instanceof Copyable<?>);
Review Comment:
`graphImplementingCopyable` is already a `Copyable` and can't be null.
##########
jena-core/src/main/java/org/apache/jena/mem2/collection/FastHashBase.java:
##########
@@ -94,7 +94,7 @@ protected FastHashBase() {
*
* @param baseToCopy
*/
- protected <T extends FastHashBase> FastHashBase(final T baseToCopy) {
+ protected <T extends FastHashBase<?>> FastHashBase(final T baseToCopy) {
Review Comment:
Generic, not bare class, keeps Eclipse happy.
##########
jena-core/src/test/java/org/apache/jena/mem2/GraphMem2Test.java:
##########
@@ -177,10 +177,10 @@ public void testCopy() {
when(mockStore.copy()).thenReturn(mockStoreCopy);
- var sut = new GraphMem2(mockStore);
- var copy = sut.copy();
+ GraphMem2 sut = new GraphMem2(mockStore);
+ GraphMem2 copy = sut.copy();
- assertTrue(copy instanceof GraphMem2);
+ assertNotNull(copy);
Review Comment:
`copy` is a GraphMem2 so the `instanceof` is false only if `copy` is null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
