Aklakan commented on code in PR #2413:
URL: https://github.com/apache/jena/pull/2413#discussion_r1568852094
##########
jena-arq/src/main/java/org/apache/jena/sparql/engine/main/VarFinder.java:
##########
@@ -329,12 +336,43 @@ public void visit(OpExtend opExtend) {
private void processAssignVarExprList(VarExprList varExprList) {
varExprList.forEachVarExpr((v,e)-> {
- defines.add(v) ; // Expression may eval to error -> unset?
- if ( e != null )
+ if ( e != null ) {
+ boolean isLikelyToBeDefined = isLikelyToBeDefined(e);
+ if (isLikelyToBeDefined) {
+ defines.add(v) ; // Expression may eval to error ->
unset?
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]