afs commented on PR #2395:
URL: https://github.com/apache/jena/pull/2395#issuecomment-2061533423
Thanks for pointing out that failing at `select()` is a visible change.
I'm personally in favour of consistency (my perceived idea of consistency!)
which is fail ASAP. The `QueryExec` has been created and the abort operation is
on that.
```
qexec.abort();
qexec.select();
```
`select()` does already get questions asked so why is it quick and then the
query is slow.
`construct()` isn't failing nor is `ask()`. `describe()` is.
`ask()` calls `.next()` once and the comment says something about timeouts.
`.hasNext()` is often the place where the real work has to happen because to
know whether there is a "next" , the engine has to do the work!
Suggestion: merge this PR as a step forward (a couple of warnings have
appeared - `cancelSignal` is now a member and being hidden by the inner class
timeout) addressing #2394 and do more in another issue/PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For additional commands, e-mail: pr-h...@jena.apache.org
