arne-bdt commented on code in PR #2477:
URL: https://github.com/apache/jena/pull/2477#discussion_r1605539624
##########
jena-arq/src/main/java/org/apache/jena/riot/lang/rdfxml/rrx/ParserRDFXML_SAX.java:
##########
@@ -1042,15 +1040,21 @@ private String xmlLang(Attributes attributes, Position
position) {
return langStr;
}
-
private ObjectParseType objectParseType(String parseTypeStr, Position
position) {
if ( parseTypeStr == null )
return ObjectParseType.Plain;
try {
String parseTypeName = parseTypeStr;
- if ( parseTypeName.equals("literal") ) {
- Log.warn(SysRIOT.getLogger(), "Encountered
rdf:parseType='literal'. Treated as rdf:parseType='literal'");
- parseTypeName = "Literal";
+ switch(parseTypeName) {
+ case "literal" -> {
+ RDFXMLparseWarning("Encountered rdf:parseType='literal'.
Treated as rdf:parseType='literal'", position);
+ parseTypeName = "Literal";
+ }
+ // CIM (Common Information Model) - see github issue 2473
+ case "Statements" -> {
+ RDFXMLparseWarning("Encountered
rdf:parseType='Statements'. Treated as rdf:parseType='literal'", position);
+ parseTypeName = "Literal";
Review Comment:
I think this is incorrect. The original `if
(parseTypeName.equals("literal")) {` should only issue a warning if someone
accidentally wrote 'Literal' in lowercase. Therefore, if we extend the same
logic to 'Statements', the case should be written in lowercase as 'statements',
and the warning should be: 'Encountered rdf:parseType="statements". Treated as
rdf:parseType="Literal."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For additional commands, e-mail: pr-h...@jena.apache.org
