afs commented on code in PR #2461:
URL: https://github.com/apache/jena/pull/2461#discussion_r1615171270
##########
jena-core/src/main/java/org/apache/jena/vocabulary/OWL.java:
##########
@@ -20,178 +20,11 @@
///////////////////////////////////////
package org.apache.jena.vocabulary;
-// Imports
-///////////////////////////////////////
-import org.apache.jena.rdf.model.* ;
-
/**
* Vocabulary definitions from file:vocabularies/owl.owl
+ *
+ * @deprecated use {@link OWL1} or {@link OWL2}
*/
-public class OWL {
- // These will use ResourceFactory which creates Resource etc without a
specific model.
- // This is safer for complex initialization paths.
- protected static final Resource resource( String uri )
- { return ResourceFactory.createResource( NS+uri ); }
-
- protected static final Property property( String uri )
- { return ResourceFactory.createProperty( NS, uri ); }
-
- /** The namespace of the vocabulary as a string. */
- public static final String NS = "http://www.w3.org/2002/07/owl#";;
-
- /** The namespace of the vocabulary as a string */
- public static String getURI() {return NS;}
-
- /** The namespace of the vocabulary as a resource */
- public static final Resource NAMESPACE = ResourceFactory.createResource(
NS );
-
- /** A resource that denotes the OWL-full sublanguage of OWL */
- public static final Resource FULL_LANG = ResourceFactory.createResource(
getURI() );
-
- /** A resource, not officially sanctioned by WebOnt, that denotes the
OWL-DL sublanguage of OWL */
- public static final Resource DL_LANG =
ResourceFactory.createResource("http://www.w3.org/TR/owl-features/#term_OWLDL";
);
-
- /** A resource, not officially sanctioned by WebOnt, that denotes the
OWL-Lite sublanguage of OWL */
- public static final Resource LITE_LANG =
ResourceFactory.createResource("http://www.w3.org/TR/owl-features/#term_OWLLite";
);
-
- // Vocabulary properties
- ///////////////////////////
-
- public static final Property maxCardinality = Init.maxCardinality();
-
- public static final Property versionInfo = Init.versionInfo();
-
- public static final Property equivalentClass = Init.equivalentClass();
-
- public static final Property distinctMembers = Init.distinctMembers();
-
- public static final Property oneOf = Init.oneOf();
-
- public static final Property sameAs = Init.sameAs();
-
- public static final Property incompatibleWith = Init.incompatibleWith();
-
- public static final Property minCardinality = Init.minCardinality();
-
- public static final Property complementOf = Init.complementOf();
-
- public static final Property onProperty = Init.onProperty();
-
- public static final Property equivalentProperty =
Init.equivalentProperty();
-
- public static final Property inverseOf = Init.inverseOf();
-
- public static final Property backwardCompatibleWith =
Init.backwardCompatibleWith();
-
- public static final Property differentFrom = Init.differentFrom();
-
- public static final Property priorVersion = Init.priorVersion();
-
- public static final Property imports = Init.imports();
-
- public static final Property allValuesFrom = Init.allValuesFrom();
-
- public static final Property unionOf = Init.unionOf();
-
- public static final Property hasValue = Init.hasValue();
-
- public static final Property someValuesFrom = Init.someValuesFrom();
-
- public static final Property disjointWith = Init.disjointWith();
-
- public static final Property cardinality = Init.cardinality();
-
- public static final Property intersectionOf = Init.intersectionOf();
-
- // Vocabulary classes
- ///////////////////////////
-
- public static final Resource Thing = Init.Thing();
-
- public static final Resource DataRange = Init.DataRange();
-
- public static final Resource Ontology = Init.Ontology();
-
- public static final Resource DeprecatedClass = Init.DeprecatedClass();
-
- public static final Resource AllDifferent = Init.AllDifferent();
-
- public static final Resource DatatypeProperty = Init.DatatypeProperty();
-
- public static final Resource SymmetricProperty = Init.SymmetricProperty();
-
- public static final Resource TransitiveProperty =
Init.TransitiveProperty();
-
- public static final Resource DeprecatedProperty =
Init.DeprecatedProperty();
-
- public static final Resource AnnotationProperty =
Init.AnnotationProperty();
-
- public static final Resource Restriction = Init.Restriction();
-
- public static final Resource Class = Init.Class();
-
- public static final Resource OntologyProperty = Init.OntologyProperty();
-
- public static final Resource ObjectProperty = Init.ObjectProperty();
-
- public static final Resource FunctionalProperty =
Init.FunctionalProperty();
-
- public static final Resource InverseFunctionalProperty =
Init.InverseFunctionalProperty();
-
- public static final Resource Nothing = Init.Nothing();
-
- // Vocabulary individuals
- ///////////////////////////
-
- /** OWL constants are used during Jena initialization.
- * <p>
- * If that initialization is triggered by touching the OWL class,
- * then the constants are null.
- * <p>
- * So for these cases, call this helper class: Init.function()
- */
- public static class Init {
- // JENA-1294
- // Version that calculate the constant when called.
- public static Property maxCardinality() { return property(
"maxCardinality" ); }
- public static Property versionInfo() { return property(
"versionInfo" ); }
- public static Property equivalentClass() { return property(
"equivalentClass" ); }
- public static Property distinctMembers() { return property(
"distinctMembers" ); }
- public static Property oneOf() { return property(
"oneOf" ); }
- public static Property sameAs() { return property(
"sameAs" ); }
- public static Property incompatibleWith() { return property(
"incompatibleWith" ); }
- public static Property minCardinality() { return property(
"minCardinality" ); }
- public static Property complementOf() { return property(
"complementOf" ); }
- public static Property onProperty() { return property(
"onProperty" ); }
- public static Property equivalentProperty() { return property(
"equivalentProperty" ); }
- public static Property inverseOf() { return property(
"inverseOf" ); }
- public static Property backwardCompatibleWith() { return property(
"backwardCompatibleWith" ); }
- public static Property differentFrom() { return property(
"differentFrom" ); }
- public static Property priorVersion() { return property(
"priorVersion" ); }
- public static Property imports() { return property(
"imports" ); }
- public static Property allValuesFrom() { return property(
"allValuesFrom" ); }
- public static Property unionOf() { return property(
"unionOf" ); }
- public static Property hasValue() { return property(
"hasValue" ); }
- public static Property someValuesFrom() { return property(
"someValuesFrom" ); }
- public static Property disjointWith() { return property(
"disjointWith" ); }
- public static Property cardinality() { return property(
"cardinality" ); }
- public static Property intersectionOf() { return property(
"intersectionOf" ); }
- public static Resource Thing() { return resource(
"Thing" ); }
- public static Resource DataRange() { return resource(
"DataRange" ); }
- public static Resource Ontology() { return resource(
"Ontology" ); }
- public static Resource DeprecatedClass() { return resource(
"DeprecatedClass" ); }
- public static Resource AllDifferent() { return resource(
"AllDifferent" ); }
- public static Resource DatatypeProperty() { return resource(
"DatatypeProperty" ); }
- public static Resource SymmetricProperty() { return resource(
"SymmetricProperty" ); }
- public static Resource TransitiveProperty() { return resource(
"TransitiveProperty" ); }
- public static Resource DeprecatedProperty() { return resource(
"DeprecatedProperty" ); }
- public static Resource AnnotationProperty() { return resource(
"AnnotationProperty" ); }
- public static Resource Restriction() { return resource(
"Restriction" ); }
- public static Resource Class() { return resource(
"Class" ); }
- public static Resource OntologyProperty() { return resource(
"OntologyProperty" ); }
- public static Resource ObjectProperty() { return resource(
"ObjectProperty" ); }
- public static Resource FunctionalProperty() { return resource(
"FunctionalProperty" ); }
- public static Resource InverseFunctionalProperty() { return resource(
"InverseFunctionalProperty" ); }
- public static Resource Nothing() { return resource(
"Nothing" ); }
- }
+@Deprecated
+public class OWL extends OWL1 {
Review Comment:
I don't see `PersistentGraphRepositoryTest` in the PR code base - I have
this pulled PR as of commit 648852b. The warnings count looks the same as
before.
1/
The situation in the stacktrace usually means the code is already inside
`JenaSystem.init`.
There is call to `JenaSystem.init` here because code may use `NodeFactory`
as a first call into Jena.
tests suite can sometimes need their own `JenaSystem.init` because they do
tend to go straight the non-public code they are testing.
`PersistentGraphRepository` looks like a entry point (a place where a first
call happens) - maybe it needs `static { `JenaSystem.init(): }`
Calling `JenaSystem.init` should always be safe. I can't see from at the
stacktrace how the code got to
`org.apache.jena.riot.lang.ReaderTriX.<clinit>(ReaderTriX.java:119)`.
`PersistentGraphRepositoryTest` may need a call to `JenaSystem.init`. If
that does not help, then, yes, this may need to go back to the old way of
initializing. which was for this this case but IIRC before ServiceLoader came
along.
2/
This isn't the cause - it may help generally.
jena-ontapi does not have a
`src/main/resources/META-INF/services/org.apache.jena.sys.JenaSubsystemLifecycle`
file.
See `jena-core` for an example. Having one of these, controls the
initlialization order in Jena so it can go after jena-core before jena-arq at
level 15 (see `JenaSystem` for details).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For additional commands, e-mail: pr-h...@jena.apache.org
