Aklakan commented on code in PR #2581:
URL: https://github.com/apache/jena/pull/2581#discussion_r1679300850
##########
jena-rdfconnection/src/main/java/org/apache/jena/rdflink/RDFLinkFuseki.java:
##########
@@ -69,7 +69,7 @@ private static RDFLinkHTTPBuilder
setupForFuseki(RDFLinkHTTPBuilder builder) {
.acceptHeaderSelectQuery(ResultSetLang.RS_Thrift.getHeaderString())
.acceptHeaderAskQuery(ResultSetLang.RS_JSON.getHeaderString())
.acceptHeaderQuery(acceptHeaderSPARQL)
- .parseCheckSPARQL(false)
+ .parseCheckSPARQL(true)
Review Comment:
Thinking about this issue, the code in question is:
```java
QueryExec qExec = link.newQuery().query("SELECT ?X { }")
.substitution(binding)
.build();
```
The problem is that the link has checkParse disabled, but substitution
requires a query object.
I think it would be best if methods that require a object would attempt to
parse a given query string when needed.
The alternative would be having to explicitly write
`remoteLink.newQuery().checkParse(true).query("SELECT ?X {
}").substitution(...).build()` which doesn't feel natural.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For additional commands, e-mail: pr-h...@jena.apache.org
