kinow commented on code in PR #2768:
URL: https://github.com/apache/jena/pull/2768#discussion_r1797718743


##########
jena-fuseki2/jena-fuseki-ui/src/utils/query.js:
##########
@@ -49,6 +49,6 @@ export function createShareableLink (query, path) {
     path +
     '?' +
     // Same as YASGUI does, good idea to avoid security problems...
-    queryString.stringify({ query })
+    qs.stringify({ query })

Review Comment:
   ```
   kinow@ranma:~/Development/java/workspace/jena/jena-fuseki2/jena-fuseki-ui$ 
yarn why query-string
   yarn why v1.22.22
   [1/4] Why do we have the module "query-string"...?
   [2/4] Initialising dependency graph...
   [3/4] Finding dependency...
   [4/4] Calculating file sizes...
   => Found "query-string@6.14.1"
   info Reasons this module exists
      - "@zazuko#yasqe" depends on it
      - Hoisted from "@zazuko#yasqe#query-string"
   info Disk size without dependencies: "52KB"
   info Disk size with unique dependencies: "120KB"
   info Disk size with transitive dependencies: "120KB"
   info Number of shared dependencies: 4
   Done in 0.17s.
   
   
   kinow@ranma:~/Development/java/workspace/jena/jena-fuseki2/jena-fuseki-ui$ 
yarn why qs
   yarn why v1.22.22
   [1/4] Why do we have the module "qs"...?
   [2/4] Initialising dependency graph...
   [3/4] Finding dependency...
   [4/4] Calculating file sizes...
   => Found "qs@6.13.0"
   info Reasons this module exists
      - "express" depends on it
      - Hoisted from "express#qs"
      - Hoisted from "cypress#@cypress#request#qs"
      - Hoisted from "express#body-parser#qs"
      - Hoisted from "@zazuko#yasqe#superagent#qs"
      - Hoisted from "@zazuko#yasqe#superagent#formidable#qs"
   info Disk size without dependencies: "616KB"
   info Disk size with unique dependencies: "740KB"
   info Disk size with transitive dependencies: "1.66MB"
   info Number of shared dependencies: 13
   Done in 0.18s.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For additional commands, e-mail: pr-h...@jena.apache.org

Reply via email to