Ostrzyciel commented on PR #2798: URL: https://github.com/apache/jena/pull/2798#issuecomment-2439721022
> Doesn't this allow for possible multithreading issues though? While with the `final` map that's mitigated... maybe looking at other data structures/map implementations could solve it in a different way (there's a comment about ligher impl...) The class is not thread-safe anyway, because `HashMap` is not thread-safe, so... it should be OK? We would have to worry about it if we had a shared instance of `ValidationState` across multiple parsers, but we don't. Long-term, I think this would be a good idea, but for that to happen I think most of this random xerces bloat would have to be removed first, as it's mostly dead code anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org For additional commands, e-mail: pr-h...@jena.apache.org
