afs commented on code in PR #2822:
URL: https://github.com/apache/jena/pull/2822#discussion_r1846689204
##########
jena-arq/src/main/java/org/apache/jena/sparql/engine/iterator/QueryIterProcessBinding.java:
##########
@@ -49,7 +49,7 @@ public QueryIterProcessBinding(QueryIterator qIter,
ExecutionContext context) {
nextBinding = null ;
AtomicBoolean signal;
try {
- signal = context.getContext().get(ARQConstants.symCancelQuery);
Review Comment:
Import `ARQConstants` no longer used.
##########
jena-arq/src/main/java/org/apache/jena/sparql/util/Context.java:
##########
@@ -20,13 +20,16 @@
import java.util.*;
import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.atomic.AtomicBoolean;
import java.util.function.BiConsumer;
import org.apache.jena.atlas.lib.Lib;
+import org.apache.jena.atlas.logging.Log;
import org.apache.jena.query.ARQ;
import org.apache.jena.sparql.ARQConstants;
import org.apache.jena.sparql.ARQException;
import org.apache.jena.sparql.core.DatasetGraph;
+import org.apache.jena.sparql.engine.ExecutionContext;
Review Comment:
Unused import.
##########
jena-integration-tests/src/test/java/org/apache/jena/test/rdfconnection/TestRDFConnectionRemote.java:
##########
@@ -228,11 +230,27 @@ public void non_standard_syntax_update_remote_3c() {
/** Standard update syntax with substitution should work. */
@Test
public void standard_syntax_update_remote_1a() {
+ RDFNode FALSE = ResourceFactory.createTypedLiteral(false);
try ( RDFConnection conn =
RDFConnectionRemote.service(server.datasetURL("/ds")).parseCheckSPARQL(false).build()
) {
conn.newUpdate()
- .update("INSERT DATA { <a> <b> <c> }")
- .update("INSERT DATA { <x> <y> <z> }")
- .substitution("foo", RDF.type).build();
+ .update("INSERT { <a> <b> <c> } WHERE { FILTER(?foo) }")
+ .update("INSERT { <x> <y> <z> } WHERE { FILTER(?foo) }")
+ .substitution("foo", FALSE)
+ .build()
+ .execute();
+ }
+ }
+
+ /** Standard update syntax with substitution should work when comments are
involved. */
+ @Test
+ public void standard_syntax_update_remote_2b() {
Review Comment:
No problem having it here.
Using "rebase and merge" means the git history doesn't retain the branch
structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
