kinow commented on code in PR #2845:
URL: https://github.com/apache/jena/pull/2845#discussion_r1847296121
##########
jena-fuseki2/jena-fuseki-main/src/main/java/org/apache/jena/fuseki/main/cmds/DSGSetup.java:
##########
@@ -46,40 +61,78 @@
if ( IO.isEmptyDirectory(directory) ) {
if ( useTDB2 )
- setupTDB2(directory, serverConfig);
+ setupTDB2(log, directory, serverArgs);
else
- setupTDB1(directory, serverConfig);
+ setupTDB1(log, directory, serverArgs);
return;
}
// Exists, not empty or does not exist
if ( TDBOps.isTDB1(directory) ) {
- setupTDB1(directory, serverConfig);
+ setupTDB1(log, directory, serverArgs);
return;
} else if ( TDBOps.isTDB2(directory) ) {
- setupTDB2(directory, serverConfig);
+ setupTDB2(log, directory, serverArgs);
return;
} else
throw new CmdException("Directory not a database: " + directory);
}
- private static void setupTDB1(String directory, ServerConfig serverConfig)
{
- serverConfig.datasetDescription = "TDB1 dataset: location="+directory;
- serverConfig.dsg = TDB1Factory.createDatasetGraph(directory);
+ private static void setupTDB1(Logger log, String directory, ServerArgs
serverArgs) {
+ serverArgs.datasetDescription = "TDB1 dataset: location="+directory;
+ serverArgs.dsg = TDB1Factory.createDatasetGraph(directory);
}
- private static void setupTDB2(String directory, ServerConfig serverConfig)
{
- serverConfig.datasetDescription = "TDB2 dataset: location="+directory;
- serverConfig.dsg = DatabaseMgr.connectDatasetGraph(directory);
+ private static void setupTDB2(Logger log, String directory, ServerArgs
serverArgs) {
+ serverArgs.datasetDescription = "TDB2 dataset: location="+directory;
+ serverArgs.dsg = DatabaseMgr.connectDatasetGraph(directory);
}
- public static void setupMemTDB(boolean useTDB2, ServerConfig serverConfig)
{
+ /*package*/ static void setupMemTDB(Logger log, boolean useTDB2,
ServerArgs serverArgs) {
String tag = useTDB2 ? "TDB2" : "TDB1";
- serverConfig.datasetDescription = tag+" dataset in-memory";
- serverConfig.dsg = useTDB2
+ serverArgs.datasetDescription = tag+" dataset in-memory";
+ serverArgs.dsg = useTDB2
? DatabaseMgr.createDatasetGraph()
: TDB1Factory.createDatasetGraph();
- serverConfig.allowUpdate = true;
+ serverArgs.allowUpdate = true;
+ }
+
+ /*package*/ static void setupMem(Logger log, ServerArgs serverArgs) {
+ serverArgs.datasetDescription = "in-memory";
+ serverArgs.dsg = DatasetGraphFactory.createTxnMem();
+ serverArgs.allowUpdate = true;
+ }
+
+ /*package*/ static void setupFile(Logger log, List<String> filenames,
ServerArgs serverArgs) {
+ serverArgs.datasetDescription = "in-memory, with files loaded";
+ serverArgs.dsg = DatasetGraphFactory.createTxnMem();
+
+ for(String filename : filenames ) {
Review Comment:
s/for(/for (/ ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
